Export useful fields and functions #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also enables interoperation with other image software that is already using the stdlib image.Point type. Signed-off-by: Chris Waldon <christopher.waldon.dev@gmail.com>
This function is really useful for doing your own image processing pipeline using the tools in this package. I would need to reimplement it if it wasn't exported. Signed-off-by: Chris Waldon <christopher.waldon.dev@gmail.com>
esimov
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
@whereswaldon that's a good observation. Definitely it's a better approach using a built in function which exposes other points related operations and methods, then implementing your own according to your needs. PR merged it to back to the main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply replaces this package's Point type with the stdlib equivalent (which is structurally identical) and exports a useful image format conversion helper. Both of these changes make it easier to build custom image processing pipelines atop this package.